-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kubernetes/data_source_kubernetes_persistent_volume.go
#2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhouston
requested changes
Jun 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add the version to the resource name. Otherwise, this looks good 🚀
kubernetes/provider.go
Outdated
@@ -223,6 +223,7 @@ func Provider() *schema.Provider { | |||
"kubernetes_pod_v1": dataSourceKubernetesPod(), | |||
"kubernetes_service_account": dataSourceKubernetesServiceAccount(), | |||
"kubernetes_service_account_v1": dataSourceKubernetesServiceAccount(), | |||
"kubernetes_persistent_volume": dataSourceKubernetesPersistentVolume(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have the _v1
suffix.
Need to rebase this, too. |
* initial resource creation * initial structures commit * add flatteners and expanders * initial create/read functions * update read function * add to provider.go * add finished schema with working tfplan * fix expand on SliceEndpoints * update to TypeList * update to using TypeList * update endpoints expander * fix flattener errors * add expander for objectref and flattener for conditions * add changelog-entry * initial tests * add missing port change check and use proper read function * get update working as well as adding ForceNew to address_type attribute * finish endpoint_slice_v1_test.go * add descriptions to attributes * add docs * website-lint-fix * add validator functions to port, hostname, and addresstype * add int check * fix test format * refactor validate functions * set to correct port
* Add `tls_server_name` provider options. * Restore accidentally removed `client_certificate` parameter. * Fixed description * add changelog-entry --------- Co-authored-by: Mauricio Alvarez Leon <[email protected]> Co-authored-by: BBBmau <[email protected]>
Co-authored-by: Alex Somesan <[email protected]>
jrhouston
approved these changes
Jun 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
Community Note