Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubernetes/data_source_kubernetes_persistent_volume.go #2118

Merged
merged 22 commits into from
Jun 23, 2023

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented May 25, 2023

Description

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

 mau@mau-JKDT676NCP  ~/Dev/terraform-provider-kubernetes   add_persistent_volume_data_source ⍟4  make testacc TESTARGS="-run TestAccKubernetesDataSourcePV_basic"
==> Checking that code complies with gofmt requirements...
go vet .
TF_ACC=1 go test "/Users/mau/Dev/terraform-provider-kubernetes/kubernetes" -v -run TestAccKubernetesDataSourcePV_basic -timeout 3h
=== RUN   TestAccKubernetesDataSourcePV_basic
--- PASS: TestAccKubernetesDataSourcePV_basic (5.77s)
PASS
ok      github.com/hashicorp/terraform-provider-kubernetes/kubernetes   6.528s

Release Note

Release note for CHANGELOG:

`kubernetes/data_source_kubernetes_persistent_volume.go`: Add data source for Kubernetes Persistent Volume Resource

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@BBBmau BBBmau requested a review from a team as a code owner May 25, 2023 17:56
@BBBmau BBBmau requested a review from jrhouston May 31, 2023 18:11
Copy link
Collaborator

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add the version to the resource name. Otherwise, this looks good 🚀

@@ -223,6 +223,7 @@ func Provider() *schema.Provider {
"kubernetes_pod_v1": dataSourceKubernetesPod(),
"kubernetes_service_account": dataSourceKubernetesServiceAccount(),
"kubernetes_service_account_v1": dataSourceKubernetesServiceAccount(),
"kubernetes_persistent_volume": dataSourceKubernetesPersistentVolume(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have the _v1 suffix.

@jrhouston
Copy link
Collaborator

Need to rebase this, too.

sbocinec and others added 11 commits June 22, 2023 14:04
* initial resource creation

* initial structures commit

* add flatteners and expanders

* initial create/read functions

* update read function

* add to provider.go

* add finished schema with working tfplan

* fix expand on SliceEndpoints

* update to TypeList

* update to using TypeList

* update endpoints expander

* fix flattener errors

* add expander for objectref and flattener for conditions

* add changelog-entry

* initial tests

* add missing port change check and use proper read function

* get update working as well as adding ForceNew to address_type attribute

* finish endpoint_slice_v1_test.go

* add descriptions to attributes

* add docs

* website-lint-fix

* add validator functions to port, hostname, and addresstype

* add int check

* fix test format

* refactor validate functions

* set to correct port
* Add `tls_server_name` provider options.

* Restore accidentally removed `client_certificate` parameter.

* Fixed description

* add changelog-entry

---------

Co-authored-by: Mauricio Alvarez Leon <[email protected]>
Co-authored-by: BBBmau <[email protected]>
@BBBmau BBBmau merged commit 7c0a654 into main Jun 23, 2023
@BBBmau BBBmau deleted the add_persistent_volume_data_source branch June 23, 2023 16:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants