run_trigger: retry when a "locked" error is returned #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds retries for run trigger creation. Concurrently creating run triggers on a workspace results in an error—now those errors are considered retryable for 1 minute.
Closes #169
Testing plan
I've added a new test that is able to reproduce this condition. When the test is run without the new retries, it fails with lock errors. In my initial test, 5/10 resources failed:
Output from acceptance tests
Please run the full suite of acceptance tests locally and include the output here.