run_trigger: retry when a "locked" error is returned

tfe/resource_tfe_run_trigger.go

@@ -4,8 +4,11 @@ import (
 	"fmt"
 	"github.com/hashicorp/terraform-plugin-sdk/helper/customdiff"
 	"log"
+	"strings"
+	"time"
 
 	tfe "github.com/hashicorp/go-tfe"
+	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
 )
 
@@ -90,13 +93,25 @@ func resourceTFERunTriggerCreate(d *schema.ResourceData, meta interface{}) error
 	}
 
 	log.Printf("[DEBUG] Create run trigger on workspace %s with sourceable %s", workspaceID, sourceableID)
-	runTrigger, err := tfeClient.RunTriggers.Create(ctx, workspaceID, options)
+	err := resource.Retry(1*time.Minute, func() *resource.RetryError {
+		runTrigger, err := tfeClient.RunTriggers.Create(ctx, workspaceID, options)
+		if err == nil {
+			d.SetId(runTrigger.ID)
+			return nil
+		}
+
+		if strings.Contains(err.Error(), "Run Trigger creation locked") {
+			log.Printf("[DEBUG] Run triggers are locked for workspace %s, will retry", workspaceID)
+			return resource.RetryableError(err)
+		}
+
+		return resource.NonRetryableError(err)
+	})
+
 	if err != nil {
 		return fmt.Errorf("Error creating run trigger on workspace %s with sourceable %s: %v", workspaceID, sourceableID, err)
 	}
 
-	d.SetId(runTrigger.ID)
-
 	return resourceTFERunTriggerRead(d, meta)
 }
 

tfe/resource_tfe_run_trigger_test.go

@@ -77,6 +77,25 @@ func TestAccTFERunTrigger_updateWorkspaceExternalIDToWorkspaceID(t *testing.T) {
 	})
 }
 
+func TestAccTFERunTrigger_many(t *testing.T) {
+	checks := make([]resource.TestCheckFunc, 10)
+	for i := range checks {
+		checks[i] = resource.TestCheckResourceAttrSet(fmt.Sprintf("tfe_run_trigger.foobar.%d", i), "id")
+	}
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
+		CheckDestroy: testAccCheckTFERunTriggerDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccTFERunTrigger_many,
+				Check:  resource.ComposeTestCheckFunc(checks...),
+			},
+		},
+	})
+}
+
 func TestAccTFERunTriggerImport(t *testing.T) {
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
@@ -202,3 +221,28 @@ resource "tfe_run_trigger" "foobar" {
   workspace_id = "${tfe_workspace.workspace.id}"
   sourceable_id         = "${tfe_workspace.sourceable.id}"
 }`
+
+const testAccTFERunTrigger_many = `
+resource "tfe_organization" "foobar" {
+  name  = "tst-terraform"
+  email = "[email protected]"
+}
+
+resource "tfe_workspace" "workspace" {
+  name         = "workspace-test"
+  organization = "${tfe_organization.foobar.id}"
+}
+
+resource "tfe_workspace" "sourceable" {
+  count = 10
+
+  name         = "sourceable-test-${count.index}"
+  organization = "${tfe_organization.foobar.id}"
+}
+
+resource "tfe_run_trigger" "foobar" {
+  count = 10
+
+  workspace_external_id = "${tfe_workspace.workspace.external_id}"
+  sourceable_id         = "${tfe_workspace.sourceable[count.index].external_id}"
+}`