Add Manage Membership to team organization access #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarrettSpiker
added a commit
that referenced
this pull request
Feb 15, 2023
JarrettSpiker
force-pushed
the
jspiker/manage-membership-permission
branch
from
a61ce8d to
33edd65
Compare
JarrettSpiker
force-pushed
the
jspiker/manage-membership-permission
branch
from
33edd65 to
573a1d0
Compare
nfagerlund
requested changes
Apr 20, 2023
There was a problem hiding this comment.
All right, this looks great, and it worked fine when I tested it manually. 👍🏼 One docs typo to fix... and you'll also need a passing CI run, which is complicated by a new flaky test.
I've got a PR up to fix that, or you could just pull in the commit to this PR; I'm fine either way. Fix is merged so just rebase onto main!
Once the typo's fixed and tests are green, that's an easy ✅ from me.
website/docs/r/team.html.markdown
Outdated
| @@ -54,6 +54,7 @@ The `organization_access` block supports: | |||
| * `manage_modules` - (Optional) Allow members to publish and delete modules in the organization's private registry. | |||
| * `manage_run_tasks` - (Optional) Allow members to create, edit, and delete the organization's run tasks. | |||
| * `manage_projects` - (Optional) Allow members to create and administrate all projects within the organization. Requires `manage_workspaces` to be set to `true`. | |||
| * `manage_membership` - (Optional) Allow members to add /remove users from the organization, and to add/remove users from visible teams. | |||
There was a problem hiding this comment.
Suggested change
| * `manage_membership` - (Optional) Allow members to add /remove users from the organization, and to add/remove users from visible teams. | |
| * `manage_membership` - (Optional) Allow members to add/remove users from the organization, and to add/remove users from visible teams. |
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ BREAKING CHANGES: | |||
| FEATURES: | |||
|
|
|||
| ENHANCEMENTS: | |||
| * `r/tfe_team`: Add attribute `manage_membership` to `organization_access` on `tfe_team` by @JarrettSpiker ([#801](https://github.com/hashicorp/terraform-provider-tfe/pull/801)) | |||
There was a problem hiding this comment.
I think I'd call that a feature!
JarrettSpiker
force-pushed
the
jspiker/manage-membership-permission
branch
from
573a1d0 to
54554aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow the manage membership organization access setting to be set on teams by the provider
Testing plan
External links
Output from acceptance tests