Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky TestAccTFEProjectDataSource_basic #861

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Fix flaky TestAccTFEProjectDataSource_basic #861

merged 1 commit into from
Apr 20, 2023

Conversation

nfagerlund
Copy link
Member

Description

This new test is flaky, because it tests the effect of the workspace resource on the project data source, but doesn't ensure that the workspace resource is processed first. Simple enough: just do that.

Testing plan

  1. Test passes.

Output from acceptance tests

TF_ACC=1 TF_LOG_SDK_PROTO=OFF go test $(go list ./... |grep -v 'vendor') -v -run TestAccTFEProjectDataSource_basic -timeout 15m
?   	github.com/hashicorp/terraform-provider-tfe	[no test files]
=== RUN   TestAccTFEProjectDataSource_basic
--- PASS: TestAccTFEProjectDataSource_basic (18.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-tfe/tfe	18.409s
?   	github.com/hashicorp/terraform-provider-tfe/version	[no test files]

@nfagerlund nfagerlund requested a review from a team as a code owner April 20, 2023 22:30
@nfagerlund nfagerlund mentioned this pull request Apr 20, 2023
Merged
annawinkler
annawinkler approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@annawinkler annawinkler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch & nice comment too! 🌟

@nfagerlund nfagerlund merged commit b9a7f45 into main Apr 20, 2023
@nfagerlund nfagerlund deleted the nf/apr23-fix-flaky-project-data-source-test branch April 20, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annawinkler annawinkler annawinkler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nfagerlund @annawinkler