Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue preventing the generation of subject key identifier for private keys using ED2551 #182

Merged
merged 8 commits into from
Apr 5, 2022
Merged

Fix issue preventing the generation of subject key identifier for private keys using ED2551 #182

merged 8 commits into from
Apr 5, 2022

Conversation

detro
Copy link
Contributor

@detro detro commented Apr 5, 2022

Closes: #181

Ivan De Marino added 5 commits April 5, 2022 10:49
Fix inability to generate "subject key ID" for ED25519
1bd0a7d 
In the process, drastically simplified its implementation.
Fixed bug where we were passing around ED25519 keys by reference, whi…
3004408 
…le it's library clearly prefers the use of copy

This is more about remain consistent with the interface of the library we are using, than actually optimal choice
Add tests to prove that we can use ED25519 keys for all our certificates
4643fc1
Use generic crypto.Signer interface when getting a `crypto.PublicKe…
2e4755f 
…y` from a `crypto.PrivateKey`
Generate Subject Key ID using ASN1 marshalling
385477b
@detro detro requested a review from a team as a code owner April 5, 2022 12:19
@detro detro requested a review from bendbennett April 5, 2022 15:48
bookshelfdave
bookshelfdave approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@bookshelfdave bookshelfdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

bflad
bflad approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few considerations, but approving to not block you. 🚀

@detro detro merged commit 8e76bad into main Apr 5, 2022
@detro detro deleted the detro/bugfix-I181 branch April 5, 2022 18:51
@detro detro changed the title Fix logic for extracting publicKey and subjectKeyId for ED25519 key Fix issue preventing the generation of subject key identifier for private keys using ED2551 Apr 5, 2022
@detro detro mentioned this pull request Apr 14, 2022
Closed
This was referenced May 9, 2022
Closed
Closed
Closed
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

@bookshelfdave bookshelfdave bookshelfdave approved these changes

@bendbennett bendbennett Awaiting requested review from bendbennett

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to sign ED25519 keys
4 participants
@detro @bookshelfdave @bflad @bendbennett