Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pkcs8 Support to Private Keys, Cert Requests, Data Sources #94

Closed
wants to merge 6 commits into from

Conversation

BojanZelic
Copy link

Resolves #91 and #55

@hashicorp-cla
Copy link

hashicorp-cla commented Dec 18, 2020

CLA assistant check
All committers have signed the CLA.

@BojanZelic
Copy link
Author

Can I get someone to look at/review this PR? @kmoe ?

Base automatically changed from master to main February 1, 2021 17:28
@komarix
Copy link

komarix commented Feb 17, 2021

Hi, Can you give an information when this feature will be available ?

@PiDelport
Copy link

What's the status of this PR?

@mariusvniekerk
Copy link

@appilon can you review this PR? These certificates would also be useful for the snowflake terraform provider

@blafry
Copy link

blafry commented Aug 2, 2021

Hello, any updates about this PR?

@simonvanderveldt
Copy link

@kmoe @bflad Could you take a look at this? I think you're the only ones that are still active that relatively recently merged something in this repo.

@haraldatbmw
Copy link

@bflad @kmoe Please merge this pull-request.

@nboaldin
Copy link

nboaldin commented Feb 2, 2022

If this is good to go I would love a merge as well.

@sescotti
Copy link

+1 for the merge. what's blocking this?

@eugeneromero
Copy link

I must add my voice to this one, is anything stopping it from being merged?

@darekzbik
Copy link

+1 I also need this functionality

@detro
Copy link
Contributor

detro commented May 9, 2022

Fixed since 3.2.1 (see #182 and related issues)

@detro detro closed this May 9, 2022
@haraldatbmw
Copy link

@detro The PR #182 does not introduce support for RSA keys in pkcs8 pem format.

@eugeneromero
Copy link

Please reopen, as mentioned by @haraldatbmw, that PR does not solve the issue from this one.

@detro detro mentioned this pull request May 10, 2022
@detro
Copy link
Contributor

detro commented May 11, 2022

Hello, thank you for reaching out.

After looking into the code better, I see now what's additional that this PR attempted to introduce, that is not available yet.

While it's possible now to consume/read PKCS#8 formatted keys, in resources that require a Key PEM or the tls_public_key data source, it's still not possible to create/write private keys and get the PEM in PKCS#8 format for them.

Given that all PRs on this topic are outdated now, I'll create a new issue and link it here.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkcs#8 output needed for resource tls_private_key