Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend/s3: add ec2_metadata_service_endpoint argument #33747

Closed
wants to merge 1 commit into from

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Aug 25, 2023

Adds ec2_metadata_service_endpoint and ec2_metadata_service_endpoint_mode arguments to the S3 backend for parity with the AWS Provider.

% TF_ACC=1 go test -count=1 ./internal/backend/remote-state/s3/...
ok      github.com/hashicorp/terraform/internal/backend/remote-state/s3 107.609s

Closes #30444
Relates #33687

Target Release

1.6.x

Draft CHANGELOG entry

UPGRADE NOTES

  • Adds ec2_metadata_service_endpoint and ec2_metadata_service_endpoint_mode arguments as well as support for the corresponding AWS environment variables, AWS_EC2_METADATA_SERVICE_ENDPOINT and AWS_EC2_METADATA_SERVICE_ENDPOINT_MODE. The environment variable AWS_METADATA_URL is also supported for compatibility with the AWS provider, but is deprecated. (#30444)

@jar-b jar-b requested a review from a team as a code owner August 25, 2023 02:05
@jar-b
Copy link
Member Author

jar-b commented Aug 29, 2023

Closing in favor of #33765, which groups the remaining AWS provider parity enhancements into a single PR.

@jar-b jar-b closed this Aug 29, 2023
@jar-b jar-b deleted the s3/ec2_metadata_service_endpoint branch August 29, 2023 20:12
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backend/s3: Add support for overriding EC2 Metadata Service endpoint
1 participant