-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backend/s3: Parity with the AWS provider configuration options #33765
Conversation
88b9a6b
to
ad3aa17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% TF_ACC=1 go test -count=1 ./internal/backend/remote-state/s3/...
ok github.com/hashicorp/terraform/internal/backend/remote-state/s3 108.948s
b434bf7
to
d05cdc1
Compare
After additional validation functions: % TF_ACC=1 go test -count=1 ./internal/backend/remote-state/s3/...
ok github.com/hashicorp/terraform/internal/backend/remote-state/s3 110.781s |
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Adds the following arguments to the S3 backend for parity with the AWS Provider.
custom_ca_bundle
ec2_metadata_service_endpoint
ec2_metadata_service_endpoint_mode
http_proxy
insecure
use_fips_endpoint
use_dualstack_endpoint
sts_region
use_path_style
(deprecatesforce_path_style
)retry_mode
Closes #33689
Closes #30444
Closes #30496
Closes #33693
Closes #30491
Closes #33692
Relates #33687
Target Release
1.6.x
Draft CHANGELOG entry
UPGRADE NOTES
custom_ca_bundle
argument and support for the corresponding AWS environment variable,AWS_CA_BUNDLE
, for providing custom root and intermediate certificates. (#33689)ec2_metadata_service_endpoint
andec2_metadata_service_endpoint_mode
arguments and support for the corresponding AWS environment variables,AWS_EC2_METADATA_SERVICE_ENDPOINT
andAWS_EC2_METADATA_SERVICE_ENDPOINT_MODE
for setting the EC2 metadata service (IMDS) endpoint. The environment variableAWS_METADATA_URL
is also supported for compatibility with the AWS provider, but is deprecated. (#30444)http_proxy
,insecure
,use_fips_endpoint
, anduse_dualstack_endpoint
arguments and support for the corresponding environment variables,HTTP_PROXY
andHTTPS_PROXY
, which enable custom HTTP proxy configurations and the use of alternative AWS endpoints. (#30496)sts_region
argument to use an alternative region for STS operations. (#33693)force_path_style
argument is deprecated in favor ofuse_path_style
for consistency with the AWS SDK. (#30491)retry_mode
argument and support for the correspondingAWS_RETRY_MODE
environment variable to configure how retries are attempted. (#33692)