Add new vault-k8s environment variables #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvoran
reviewed
Mar 6, 2020
tvoran
approved these changes
Mar 6, 2020
jmaroeder
reviewed
Mar 6, 2020
| - name: AGENT_INJECT_LOG_FORMAT | ||
| value: {{ .Values.injector.logFormat | default "standard" }} | ||
| - name: AGENT_INJECT_REVOKE_ON_SHUTDOWN | ||
| value: {{ .Values.injector.revokeOnShutdown | default false }} |
There was a problem hiding this comment.
This looks like it needs to be a string (e.g,. "default "false")
There was a problem hiding this comment.
More details:
$ helm install vault ./ --wait
Error: Deployment in version "v1" cannot be handled as a Deployment: v1.Deployment.Spec: v1.DeploymentSpec.Template: v1.PodTemplateSpec.Spec: v1.PodSpec.Containers: []v1.Container: v1.Container.Env: []v1.EnvVar: v1.EnvVar.Value: ReadString: expects " or n, but found f, error found in #10 byte of ...|,"value":false}],"im|..., bigger context ...|"name":"AGENT_INJECT_REVOKE_ON_SHUTDOWN","value":false}],"image":"hashicorp/vault-k8s:0.3.0","imageP|...There was a problem hiding this comment.
Thanks! Fixed here: #221
radudd
pushed a commit
to radudd/vault-helm
that referenced
this pull request
Jun 5, 2020
* Add new vault-k8s envs * update vault image * Add default tests for envs * Add note about supported log parameters * Fix typo in test name
hadielaham88
pushed a commit
to SolaceDev/vault-helm
that referenced
this pull request
May 19, 2021
* Add new vault-k8s envs * update vault image * Add default tests for envs * Add note about supported log parameters * Fix typo in test name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the new envs included in newest release of Vault K8s: https://github.com/hashicorp/vault-k8s/blob/master/CHANGELOG.md#030-march-5th-2020.
Updated the images to reflect the latest releases.