Change revoke from bool to string #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvoran
approved these changes
Mar 6, 2020
|
@jasonodonnell / @tvoran Please create a new release with this change, currently deploying the 0.4.0 version of this chart fails because of this issue. |
|
@tvoran Ah, hm, it's weird because we installed the 0.4.0 version (but from the master branch) and I got the error that this PR fixes. Well never mind and sorry to bother you. We should install from a tag on github anyway instead of the master branch. |
radudd
pushed a commit
to radudd/vault-helm
that referenced
this pull request
Jun 5, 2020
hadielaham88
pushed a commit
to SolaceDev/vault-helm
that referenced
this pull request
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where bool value must be string.