Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #47
Allows for roles to specify their namespaces as globbed patterns:
Two main changes:
Use
StrListContainsGlob
instead ofStrListContains
to allow forglobbed names/namespaces - seemed like the path of least resistance
Update the
setupBackend
test function to accept the test role's allowed SAname/namespace as parameters, allowing testing of globbed namespaces
Not sure if more logic around this is needed since kubernetes names are pretty limited with regard to special characters anyway.