Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for serviceaccount and namespace being * #66

Closed
wants to merge 4 commits into from
Closed

Remove check for serviceaccount and namespace being * #66

wants to merge 4 commits into from

Conversation

logandavies181
Copy link

Since #48 (#53) we're able to sensibly allow all serviceaccounts in all namespaces to authenticate to Vault, for example mapping them to a templated policy.
Since #58 we're able to get around the check by doing this:

vault write auth/kubernetes/role/myrole \
bound_service_account_names=a*,b*,c*,d*,e*,f*,h*,i*,j*,k*,l*,m*,n*,o*,p*,q*,r*,s*,t*,u*,v*,w*,x*,y*,z*,1*,2*,3*,4*,5*,6*,7*,8*,9*,0* \ 
bound_service_account_namespaces=* policies=my_templated_policy

This PR is to remove the now unnecessary check for bound_service_account_name and bound_service_account_namespace being *

logandavies181 and others added 2 commits June 28, 2019 15:52
No need to check for bound_service_account_name and namespace both being * since #48 means we can use this sensibly, and #58 means we can actually circumvent it..
@hashicorp-cla
Copy link

hashicorp-cla commented Jun 28, 2019

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


1 out of 2 committers have signed the CLA.

  • logandavies181
  • daviesl2

daviesl2 seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

daviesl2 and others added 2 commits June 28, 2019 16:27
@james-atwill-hs
Copy link

This is outstanding to finally resolve #47 .. is there a way to move this along?

@buckner
Copy link

buckner commented Dec 4, 2019

Any chance this could get looked at? @logandavies181

@tyrannosaurus-becks tyrannosaurus-becks self-assigned this Dec 11, 2019
@tyrannosaurus-becks tyrannosaurus-becks added this to the v0.6.0 milestone Dec 11, 2019
@tyrannosaurus-becks
Copy link
Contributor

Closing due to inactivity and to lack of signing the contributor agreement. However, I do still think this is an important request and will either submit a similar PR or will chat with folks about it further on #47.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants