Skip to content

Commit

Permalink
cert/tests: fix tests due to cert expiry (#6647)
Browse files Browse the repository at this point in the history
  • Loading branch information
calvn authored and Brian Kassouf committed Jun 3, 2019
1 parent d3783c5 commit f484d95
Show file tree
Hide file tree
Showing 9 changed files with 44 additions and 250 deletions.
56 changes: 44 additions & 12 deletions builtin/credential/cert/backend_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1112,18 +1112,34 @@ func TestBackend_ext_singleCert(t *testing.T) {

// Test a self-signed client with URI alt names (root CA) that is trusted
func TestBackend_dns_singleCert(t *testing.T) {
connState, err := testConnState(
"test-fixtures/root/rootcawdnscert.pem",
"test-fixtures/root/rootcawdnskey.pem",
"test-fixtures/root/rootcacert.pem",
)
certTemplate := &x509.Certificate{
Subject: pkix.Name{
CommonName: "example.com",
},
DNSNames: []string{"example.com"},
IPAddresses: []net.IP{net.ParseIP("127.0.0.1")},
ExtKeyUsage: []x509.ExtKeyUsage{
x509.ExtKeyUsageServerAuth,
x509.ExtKeyUsageClientAuth,
},
KeyUsage: x509.KeyUsageDigitalSignature | x509.KeyUsageKeyEncipherment | x509.KeyUsageKeyAgreement,
SerialNumber: big.NewInt(mathrand.Int63()),
NotBefore: time.Now().Add(-30 * time.Second),
NotAfter: time.Now().Add(262980 * time.Hour),
}

tempDir, connState, err := generateTestCertAndConnState(t, certTemplate)
if tempDir != "" {
defer os.RemoveAll(tempDir)
}
if err != nil {
t.Fatalf("error testing connection state: %v", err)
}
ca, err := ioutil.ReadFile("test-fixtures/root/rootcacert.pem")
ca, err := ioutil.ReadFile(filepath.Join(tempDir, "ca_cert.pem"))
if err != nil {
t.Fatalf("err: %v", err)
}

logicaltest.Test(t, logicaltest.TestCase{
CredentialBackend: testFactory(t),
Steps: []logicaltest.TestStep{
Expand All @@ -1143,18 +1159,34 @@ func TestBackend_dns_singleCert(t *testing.T) {

// Test a self-signed client with URI alt names (root CA) that is trusted
func TestBackend_email_singleCert(t *testing.T) {
connState, err := testConnState(
"test-fixtures/root/rootcawemailcert.pem",
"test-fixtures/root/rootcawemailkey.pem",
"test-fixtures/root/rootcacert.pem",
)
certTemplate := &x509.Certificate{
Subject: pkix.Name{
CommonName: "example.com",
},
EmailAddresses: []string{"[email protected]"},
IPAddresses: []net.IP{net.ParseIP("127.0.0.1")},
ExtKeyUsage: []x509.ExtKeyUsage{
x509.ExtKeyUsageServerAuth,
x509.ExtKeyUsageClientAuth,
},
KeyUsage: x509.KeyUsageDigitalSignature | x509.KeyUsageKeyEncipherment | x509.KeyUsageKeyAgreement,
SerialNumber: big.NewInt(mathrand.Int63()),
NotBefore: time.Now().Add(-30 * time.Second),
NotAfter: time.Now().Add(262980 * time.Hour),
}

tempDir, connState, err := generateTestCertAndConnState(t, certTemplate)
if tempDir != "" {
defer os.RemoveAll(tempDir)
}
if err != nil {
t.Fatalf("error testing connection state: %v", err)
}
ca, err := ioutil.ReadFile("test-fixtures/root/rootcacert.pem")
ca, err := ioutil.ReadFile(filepath.Join(tempDir, "ca_cert.pem"))
if err != nil {
t.Fatalf("err: %v", err)
}

logicaltest.Test(t, logicaltest.TestCase{
CredentialBackend: testFactory(t),
Steps: []logicaltest.TestStep{
Expand Down
17 changes: 0 additions & 17 deletions builtin/credential/cert/test-fixtures/root/rootcawdns.cnf

This file was deleted.

27 changes: 0 additions & 27 deletions builtin/credential/cert/test-fixtures/root/rootcawdns.csr

This file was deleted.

23 changes: 0 additions & 23 deletions builtin/credential/cert/test-fixtures/root/rootcawdnscert.pem

This file was deleted.

52 changes: 0 additions & 52 deletions builtin/credential/cert/test-fixtures/root/rootcawdnskey.pem

This file was deleted.

17 changes: 0 additions & 17 deletions builtin/credential/cert/test-fixtures/root/rootcawemail.cnf

This file was deleted.

27 changes: 0 additions & 27 deletions builtin/credential/cert/test-fixtures/root/rootcawemail.csr

This file was deleted.

23 changes: 0 additions & 23 deletions builtin/credential/cert/test-fixtures/root/rootcawemailcert.pem

This file was deleted.

52 changes: 0 additions & 52 deletions builtin/credential/cert/test-fixtures/root/rootcawemailkey.pem

This file was deleted.

0 comments on commit f484d95

Please sign in to comment.