Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cert/tests: fix tests due to cert expiry #6647

Merged
merged 1 commit into from
Apr 26, 2019
Merged

cert/tests: fix tests due to cert expiry #6647

merged 1 commit into from
Apr 26, 2019

Conversation

calvn
Copy link
Contributor

@calvn calvn commented Apr 26, 2019

Fix failing cert tests in the same fashion as #6520.

@calvn calvn added this to the next-release milestone Apr 26, 2019
@calvn calvn requested review from jfreda and briankassouf April 26, 2019 22:46
jfreda
jfreda approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, confirmed this fixed the tests - thanks!

@briankassouf briankassouf merged commit c24559c into master Apr 26, 2019
@briankassouf briankassouf deleted the cert-tests branch April 26, 2019 23:49
briankassouf pushed a commit that referenced this pull request Jun 4, 2019
@calvn
cert/tests: fix tests due to cert expiry (#6647)
f484d95
@pbernal pbernal removed this from the next-release milestone May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briankassouf briankassouf briankassouf approved these changes

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calvn @jfreda @briankassouf @pbernal