Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: update tencentcloud-sdk-go to v1.0.162 #12781

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Conversation

calvn
Copy link
Contributor

@calvn calvn commented Oct 8, 2021

Fixes build failures on systems that doesn't have a deleted revision of tencentcloud-sdk-go locally cached. v1.0.162 was chosen as the version to pin to since that's the version pinned on other HC-owned repos as well. Since both imports that end up indirectly importing this to vault now point to the same version, it seemed to have removed it from vault's go.mod entirely.

hashicorp/go-kms-wrapping#32
hashicorp/go-discover#173

Update commands:

$ go get github.com/tencentcloud/[email protected]
$ go mod tidy

The error can be consistently reproduced by forcing Go to fetch dependencies directly from the version control source.

To reproduce:

# Clean your local cache
$ go clean -modcache -cache

# Run tidy without fetching deps from proxy
$ GOPROXY=direct go mod tidy
...
go: github.com/tencentcloud/[email protected]+incompatible: reading github.com/tencentcloud/tencentcloud-sdk-go/go.mod at revision v3.0.171: unknown revision v3.0.171

Closes #12742

@calvn calvn added this to the 1.9 milestone Oct 8, 2021
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 8, 2021 20:29 Inactive
@calvn calvn merged commit dc244a7 into main Oct 12, 2021
@calvn calvn deleted the dep-tencentcloud-sdk-go branch October 12, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github.com/tencentcloud/tencentcloud-sdk-go import issue on any tag after v1.7.5
3 participants