Dashboard TLS Configuration Details Bug #23726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
zofskeez
commented
Oct 18, 2023
|
Build Results: |
kiannaquach
reviewed
Oct 18, 2023
| // consider tls enabled if tls_disable is undefined or false AND both tls_cert_file and tls_key_file are defined | ||
| const tlsListener = this.args.vaultConfiguration?.listeners.find((listener) => { | ||
| const { tls_disable, tls_cert_file, tls_key_file } = listener.config || {}; | ||
| return (tls_disable === undefined || tls_disable === false) && tls_cert_file && tls_key_file; |
There was a problem hiding this comment.
Good to know that the vault listener config gets returned with tls_cert_file and tls_key_file as an option.
Could we do !tls_disable && tls_cert_file && tls_key_file instead?
There was a problem hiding this comment.
Yes good catch! I believe that 0 and 1 are accepted in the config as well which this would not account for.
kiannaquach
reviewed
Oct 18, 2023
| @@ -19,7 +19,7 @@ | |||
| </B.Tr> | |||
| <B.Tr> | |||
| <B.Td>TLS</B.Td> | |||
| <B.Td data-test-vault-config-details="tls_disable">{{this.tlsDisabled}}</B.Td> | |||
| <B.Td data-test-vault-config-details="tls">{{this.tls}}</B.Td> | |||
kiannaquach
approved these changes
Oct 18, 2023
zofskeez
added a commit
that referenced
this pull request
Oct 19, 2023
* fixes issues displaying accurate tls state in dashboard configuration details * adds changelog entry * updates tls getter to look for falsy in configuration details card
zofskeez
added a commit
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TLS field of the configuration details section on the dashboard was not displaying accurately based on the configuration settings. Since the
tls_disabledefault value isfalse, it doesn't need to be defined and could be missing from the configuration. In addition, when using TLS thetls_cert_fileandtls_key_filevalues are required. I updated to check thattls_disableis eitherundefinedorfalseand both file properties have value to determine if TLS is enabled.The screen shot below is after the changes with the following config:
I also noticed when running a dev server that it was incorrectly reporting that TLS was Enabled which is now showing Disabled as expected.
Closes #23371