Backport of Dashboard TLS Configuration Details Bug into release/1.15.x #23727
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #23726 to be assessed for backporting due to the inclusion of the label backport/1.15.x.
🚨
The person who merged in the original PR is:
@zofskeez
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
The TLS field of the configuration details section on the dashboard was not displaying accurately based on the configuration settings. Since the
tls_disable
default value isfalse
, it doesn't need to be defined and could be missing from the configuration. In addition, when using TLS thetls_cert_file
andtls_key_file
values are required. I updated to check thattls_disable
is eitherundefined
orfalse
and both file properties have value to determine if TLS is enabled.The screen shot below is after the changes with the following config:
I also noticed when running a dev server that it was incorrectly reporting that TLS was Enabled which is now showing Disabled as expected.
Overview of commits