UI - no ember cli eslint #6613
Merged
UI - no ember cli eslint #6613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andaley
approved these changes
Apr 18, 2019
catsby
added a commit
that referenced
this pull request
Apr 22, 2019
* master: (94 commits) Add type to documentation for create in token auth API (#6622) Merge multiple functions for creating consul containers into one. (#6612) Update deep to pull in default full-level-diff behavior Update base64 decrypt command documentation (#6614) Add some missing default values (#6611) Typo fixes (#6610) UI - no ember cli eslint (#6613) Update githook to work with go mod workflows (#6604) Cut version 1.1.2 Prep for 1.1.2 changelog++ Add a get handler function (#6603) Move cluster logic out of vault package (#6601) Adding common prefix known issue to upgrade guide (#6575) changelog++ UI - write without read for kv (#6570) Add known issue section to the upgrade guide (#6593) Update pre-push hook changelog++ Fix a dropped Okta error (#6592) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing some work to move parts of the app into ember-engines I ran into this: ember-cli/ember-cli-eslint#235 (comment)
Reading through that issue, it seems like the fix is to remove ember-cli-eslint and just run ESLint itself as part of the test run.
This PR removes
ember-cli-eslint, addseslintand updateseslint-plugin-emberto the latest version. The last item bubbled up new warnings (booo), so I fixed or ignored those warnings as well (hurray).