Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update base64 decrypt command documentation #6614

Merged
merged 3 commits into from
Apr 19, 2019
Merged

Update base64 decrypt command documentation #6614

merged 3 commits into from
Apr 19, 2019

Conversation

djiang
Copy link
Contributor

@djiang djiang commented Apr 18, 2019

Running base64 -d returns base64: invalid option -- d. The correct option should be -D (capitalized)

@hashicorp-cla
Copy link

hashicorp-cla commented Apr 18, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@djiang djiang changed the title Update base64 decrypt command Update base64 decrypt command documentation Apr 18, 2019
@kalafut
Copy link
Contributor

kalafut commented Apr 19, 2019 •
edited
Loading

Thanks for the contribution. The -d option is correct for GNU base64 (https://linux.die.net/man/1/base64). Unfortunately there are number of small differences between the Mac versions of common unix utilities. --decode is common to both versions, however, and is used elsewhere in the docs.

@djiang
Copy link
Contributor Author

djiang commented Apr 19, 2019

Updated to use --decode instead

@kalafut kalafut merged commit c06b461 into hashicorp:master Apr 19, 2019
@djiang djiang deleted the dj-update-pgp-documentation branch April 19, 2019 05:40
@kalafut
Copy link
Contributor

kalafut commented Apr 19, 2019

Thanks!

kalafut pushed a commit that referenced this pull request Apr 19, 2019
@djiang
Update base64 decrypt command documentation (#6614)
df2c3ea 
* Update base64 decrypt command

* update to use --decode

* Apply suggestions from code review

Co-Authored-By: djiang <[email protected]>
catsby added a commit that referenced this pull request Apr 22, 2019
@catsby
Merge branch 'master' into cdcr
0b706a9 
* master: (94 commits)
  Add type to documentation for create in token auth API (#6622)
  Merge multiple functions for creating consul containers into one. (#6612)
  Update deep to pull in default full-level-diff behavior
  Update base64 decrypt command documentation (#6614)
  Add some missing default values (#6611)
  Typo fixes (#6610)
  UI - no ember cli eslint (#6613)
  Update githook to work with go mod workflows (#6604)
  Cut version 1.1.2
  Prep for 1.1.2
  changelog++
  Add a get handler function (#6603)
  Move cluster logic out of vault package (#6601)
  Adding common prefix known issue to upgrade guide (#6575)
  changelog++
  UI - write without read for kv (#6570)
  Add known issue section to the upgrade guide (#6593)
  Update pre-push hook
  changelog++
  Fix a dropped Okta error (#6592)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalafut kalafut kalafut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djiang @hashicorp-cla @kalafut