-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for writing configuration files #107
Comments
@DavidePastore @hassankhan I'm working on writing support in my repository. Currently, the result of writing would be minified (for example one file for JSON). Is this OK or should the result be not minified? |
@filips123 I would prefer to have the chance to choose (using configuration) if I want minified output or not. |
@DavidePastore I currently don't have much time, but I will continue implementing writing support next month. Problem is that I would have to change, add and rename methods in parsers and other classes so this would be breaking change and new major version (3.0.0). Is that OK? Would it be possible to do this without breaking changes? |
@filips123 I think you can do it without breaking changes but by only adding new methods for the purpose. If you already have something in mind you can share it with us (cc @hassankhan ) so we could discuss about it. Anyway it could make sense to create a new major version for this kind of improvement. |
@DavidePastore I created something in my repository. However, those changes are old and I will need to rewrite them because of git conflicts with new updates. |
@filips123 I like the idea behind it and the way you did it. The breaking change you were talking about before was the |
Thank you. I need to fix all git conflicts. I will then also provide support for writer configuration (#107 (comment)).
Yes. |
Add support for writing configuration files. This would be useful so developers could make user-friendly installers for configuration files.
For INI, XML, JSON, YAML and other formats, this should not be hard, because they already support writing. For PHP files, this could be harder.
Example of writing config from start:
Example of writing using existing config:
The text was updated successfully, but these errors were encountered: