Support for writing Config back to a file #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I will review your changes this Sunday. |
filips123
requested changes
Aug 18, 2019
There was a problem hiding this comment.
Is there any reason why you skipped config3 files in tests/mocks?
I think that config4 files should be renamed to config3 and tests should also be updated to use correct files.
Anyway, thank you for this PR! I will merge it when I review it completely and you fix requested changes.
filips123
requested changes
Aug 18, 2019
Config 3 is used in another test to check the case if a file does not exist. |
filips123
approved these changes
Sep 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another implementation to add the ability to write a Config back to file as discussed in #107.
Most of the heavy lifting was already done by @filips123 in https://github.com/filips123/config/tree/writing however my implementation does not contain any breaking changes and comforms with the current state of the project.