fix: fix unconditional recursion in PartialEq (#468)

hawkw · Jan 21, 2024 · 7a8c368 · 7a8c368
1 parent f78ad1f
commit 7a8c368
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/bitfield/src/pack.rs b/bitfield/src/pack.rs
@@ -769,14 +769,14 @@ macro_rules! make_packers {
             impl<A, B, F> PartialEq<&'_ $Pack<B, F>> for $Pack<A, F> {
                 #[inline]
                 fn eq(&self, other: &&'_ $Pack<B, F>) -> bool {
-                    self.eq(*other)
+                    <Self as PartialEq<$Pack<B, F>>>::eq(self, *other)
                 }
             }
 
             impl<A, B, F> PartialEq<$Pack<B, F>> for &'_ $Pack<A, F> {
                 #[inline]
                 fn eq(&self, other: &$Pack<B, F>) -> bool {
-                    (*self).eq(other)
+                    <$Pack<A, F> as PartialEq<$Pack<B, F>>>::eq(*self, other)
                 }
             }
 
@@ -1052,14 +1052,14 @@ macro_rules! make_packers {
             impl<A, B> PartialEq<&'_ $Pair<B>> for $Pair<A> {
                 #[inline]
                 fn eq(&self, other: &&'_ $Pair<B>) -> bool {
-                    self.eq(*other)
+                    <Self as PartialEq<$Pair<B>>>::eq(self, *other)
                 }
             }
 
             impl<A, B> PartialEq<$Pair<B>> for &'_ $Pair<A> {
                 #[inline]
                 fn eq(&self, other: &$Pair<B>) -> bool {
-                    (*self).eq(other)
+                    <$Pair<A> as PartialEq<$Pair<B>>>::eq(*self, other)
                 }
             }
 

diff --git a/maitake-sync/src/wait_map/tests/alloc_tests.rs b/maitake-sync/src/wait_map/tests/alloc_tests.rs
@@ -205,7 +205,7 @@ struct CountDropKey {
 
 impl PartialEq for CountDropKey {
     fn eq(&self, other: &Self) -> bool {
-        self.idx.eq(&other.idx)
+        self.idx == other.idx
     }
 }