chore: update nightly to 2024-01-20 #468
Merged
+744
−646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a missing lifetime in a `const` declaration generated by the `enum_from_bits!` macro. Adding this missing lifetime fixes a warning on recent nightly toolchains.
hawkw
force-pushed
the
eliza/nightly-2024-01-20
branch
from
fabcb2b to
1c64128
Compare
hawkw
added a commit
that referenced
this pull request
Jan 21, 2024
hawkw
added a commit
that referenced
this pull request
Jan 21, 2024
Apparently taking a reference to a `static mut` is going to be disallowed by a future compiler, and we should use `addr_of!` instead. This is because `static mut`s are only sound to access through a raw pointer.
hawkw
force-pushed
the
eliza/nightly-2024-01-20
branch
from
9dc87d0 to
f578d5f
Compare
hawkw
added a commit
that referenced
this pull request
Jan 21, 2024
hawkw
added a commit
that referenced
this pull request
Jan 21, 2024
This commit fixes a missing lifetime in a `const` declaration generated by the `enum_from_bits!` macro. Adding this missing lifetime fixes a warning on recent nightly toolchains.
hawkw
added a commit
that referenced
this pull request
Jan 21, 2024
hawkw
added a commit
that referenced
this pull request
Jan 21, 2024
hawkw
added a commit
that referenced
this pull request
Jan 21, 2024
hawkw
added a commit
that referenced
this pull request
Jan 21, 2024
hawkw
added a commit
that referenced
this pull request
Jan 21, 2024
hawkw
added a commit
that referenced
this pull request
Jan 21, 2024
hawkw
added a commit
that referenced
this pull request
Jan 21, 2024
Apparently taking a reference to a `static mut` is going to be disallowed by a future compiler, and we should use `addr_of!` instead. This is because `static mut`s are only sound to access through a raw pointer.
hawkw
added a commit
that referenced
this pull request
Jan 21, 2024
hawkw
added a commit
that referenced
this pull request
Jan 21, 2024
hawkw
added a commit
that referenced
this pull request
Jan 21, 2024
hawkw
added a commit
that referenced
this pull request
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.