Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add try_recv method for mpsc channels #60

Merged
merged 2 commits into from
Apr 23, 2022
Merged

add try_recv method for mpsc channels #60

merged 2 commits into from
Apr 23, 2022

Conversation

name1e5s
Copy link
Contributor

No description provided.

hawkw
hawkw requested changes Apr 22, 2022
View reviewed changes
Copy link
Owner

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Overall, this change looks correct, but before we can merge it, we'll want to add some missing documentation to some of the new methods. Also, we'll need to add missing trait impls for the new error type.

Once those changes are addressed, I'll be very happy to merge this!

src/mpsc/async_impl.rs Outdated Show resolved Hide resolved
src/mpsc/async_impl.rs Outdated Show resolved Hide resolved
src/mpsc/async_impl.rs Outdated Show resolved Hide resolved
src/mpsc/blocking.rs Outdated Show resolved Hide resolved
src/mpsc/errors.rs Show resolved Hide resolved
src/mpsc.rs Outdated Show resolved Hide resolved
hawkw
hawkw approved these changes Apr 23, 2022
View reviewed changes
Copy link
Owner

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for addressing my suggestions, this looks good to me!

@hawkw hawkw enabled auto-merge (squash) April 23, 2022 16:07
@hawkw hawkw merged commit e04661f into hawkw:main Apr 23, 2022
hawkw added a commit that referenced this pull request May 13, 2022
@hawkw
chore: prepare to release v0.1.3
9e037dc 
<a name="v0.1.3"></a>
### v0.1.3 (2022-05-13)

#### Features

* **mpsc:**  add `Receiver::try_recv` method  (#60) ([e04661f](e04661f))

#### Bug Fixes

* **mpsc:**  `try_recv_ref` should return `RecvRef` (#61) ([47f16f5](47f16f5))
@hawkw hawkw mentioned this pull request May 13, 2022
Merged
hawkw added a commit that referenced this pull request May 13, 2022
@hawkw
chore: prepare to release v0.1.3 (#64)
3124307 
<a name="v0.1.3"></a>
### v0.1.3 (2022-05-13)

#### Features

* **mpsc:**  add `Receiver::try_recv` method  (#60) ([e04661f](e04661f))

#### Bug Fixes

* **mpsc:**  `try_recv_ref` should return `RecvRef` (#61) ([47f16f5](47f16f5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@name1e5s @hawkw