Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: try_recv_ref should return RecvRef #61

Merged
merged 1 commit into from
May 11, 2022
Merged

fix: try_recv_ref should return RecvRef #61

merged 1 commit into from
May 11, 2022

Conversation

name1e5s
Copy link
Contributor

@name1e5s name1e5s commented Apr 26, 2022 •
edited
Loading

try_recv_ref should return a RecvRef to notify the sender threads to wake up.

@hawkw r?

hawkw
hawkw approved these changes May 8, 2022
View reviewed changes
Copy link
Owner

@hawkw hawkw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this looks good to me.

we probably should have written some tests exercising try_recv_ref so we would have caught this sooner...are you interested in adding some now? this would be fine to do in a separate PR...

@name1e5s
Copy link
Contributor Author

name1e5s commented May 9, 2022

thanks, this looks good to me.

we probably should have written some tests exercising try_recv_ref so we would have caught this sooner...are you interested in adding some now? this would be fine to do in a separate PR...

Hmm, I'll write some tests and submit a new PR this Friday.

@hawkw hawkw merged commit 47f16f5 into hawkw:main May 11, 2022
@hawkw
Copy link
Owner

hawkw commented May 11, 2022

@name1e5s sounds good --- I went ahead and merged the bugfix. Thank you!

hawkw added a commit that referenced this pull request May 13, 2022
@hawkw
chore: prepare to release v0.1.3
9e037dc 
<a name="v0.1.3"></a>
### v0.1.3 (2022-05-13)

#### Features

* **mpsc:**  add `Receiver::try_recv` method  (#60) ([e04661f](e04661f))

#### Bug Fixes

* **mpsc:**  `try_recv_ref` should return `RecvRef` (#61) ([47f16f5](47f16f5))
@hawkw hawkw mentioned this pull request May 13, 2022
Merged
hawkw added a commit that referenced this pull request May 13, 2022
@hawkw
chore: prepare to release v0.1.3 (#64)
3124307 
<a name="v0.1.3"></a>
### v0.1.3 (2022-05-13)

#### Features

* **mpsc:**  add `Receiver::try_recv` method  (#60) ([e04661f](e04661f))

#### Bug Fixes

* **mpsc:**  `try_recv_ref` should return `RecvRef` (#61) ([47f16f5](47f16f5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@name1e5s @hawkw