Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus-adapter] Add support for image pull secrets #10269

Merged
merged 3 commits into from
Jan 15, 2019
Merged

[stable/prometheus-adapter] Add support for image pull secrets #10269

merged 3 commits into from
Jan 15, 2019

Conversation

ivanmp91
Copy link
Contributor

Added support to pull custom metrics image from private registry using k8s secrets for registry authentication.

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 27, 2018
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 27, 2018
@paulczar
Copy link
Collaborator

paulczar commented Jan 2, 2019

please sign your commits (dco) and fix the conflicts

@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 3, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2019
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 3, 2019
@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2019
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 3, 2019
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 3, 2019
@ivanmp91
Copy link
Contributor Author

ivanmp91 commented Jan 3, 2019

please sign your commits (dco) and fix the conflicts

Done!

@ivanmp91
Copy link
Contributor Author

@paulczar Do you need me for anything else or you're ready to merge this changes?

@cpanato
Copy link
Member

cpanato commented Jan 11, 2019

@ivanmp91 please sign the DCO

@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 14, 2019
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 14, 2019
@ivanmp91
Copy link
Contributor Author

@cpanato Thanks! I've done all the changes requested. Please let me know if you need anything else!

@davidkarlsen
Copy link
Member

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. labels Jan 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, ivanmp91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3c951bb into helm:master Jan 15, 2019
@ivanmp91 ivanmp91 mentioned this pull request Jan 17, 2019
Merged
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
@ivanmp91 @wgiddens
Add support for image pull secrets for api server deployment (helm#10269
4423bb6 
)

Signed-off-by: Iván Mora <[email protected]>
hakamadare pushed a commit to hakamadare/charts that referenced this pull request Jan 29, 2019
@ivanmp91 @hakamadare
Add support for image pull secrets for api server deployment (helm#10269
126a3f0 
)

Signed-off-by: Iván Mora <[email protected]>
hakamadare pushed a commit to hakamadare/charts that referenced this pull request Jan 29, 2019
@ivanmp91 @hakamadare
Add support for image pull secrets for api server deployment (helm#10269
2e8ad56 
)

Signed-off-by: Iván Mora <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cpanato cpanato cpanato left review comments

@lachie83 lachie83 Awaiting requested review from lachie83

@paulczar paulczar Awaiting requested review from paulczar

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ivanmp91 @paulczar @cpanato @davidkarlsen @k8s-ci-robot @helm-bot