This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Fix/prometheus adapter image pull secrets #10725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
the
size/S
helm-bot
added
size/S
added 2 commits
January 17, 2019 12:33
Signed-off-by: Iván Mora <[email protected]>
Signed-off-by: Iván Mora <[email protected]>
helm-bot
added
Contribution Allowed
|
/ok-to-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, ivanmp91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
wgiddens
pushed a commit
to wgiddens/charts
that referenced
this pull request
Jan 18, 2019
* Move image pull secret block to a proper place Signed-off-by: Iván Mora <[email protected]> * Bump chart version Signed-off-by: Iván Mora <[email protected]>
victorboissiere
pushed a commit
to victorboissiere/charts
that referenced
this pull request
Jan 24, 2019
* Move image pull secret block to a proper place Signed-off-by: Iván Mora <[email protected]> * Bump chart version Signed-off-by: Iván Mora <[email protected]> Signed-off-by: Victor Boissiere <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with already merged PR #10269 (cc @cpanato ). This has been my bad, sorry guys! I've properly tested it and now it's working fine!
➜ helm upgrade --install --namespace custom-metrics custom-metrics . --set prometheus-adapter.image.pullSecrets={registry.internal-cluster.io.lan} --debug
[debug] Created tunnel using local port: '55514'
[debug] SERVER: "127.0.0.1:55514"
REVISION: 11
RELEASED: Thu Jan 17 12:24:26 2019
CHART: custom-metrics-0.3.0
USER-SUPPLIED VALUES:
prometheus-adapter:
image:
pullSecrets:
- registry.internal-cluster.io.lan
COMPUTED VALUES:
prometheus-adapter:
affinity: {}
global: {}
image:
pullPolicy: IfNotPresent
pullSecrets:
- registry.internal-cluster.io.lan