Prometheus: default to alpha dynamic PV annotation #235
Conversation
Addresses #227 Alpha dynamic provisioner only looks for annotation, not value. To enable the beta provisioner, operator provides `.Values.{alertmanager|server}.persistentVolume.storageClass`.
|
Can a kubernetes member verify that this patch is reasonable to test? If so, please reply with "@k8s-bot ok to test" on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands will still work. Regular contributors should join the org to skip this step.
If you have questions or suggestions related to this bot's behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
|
k8s-ci-robot
added
the
cncf-cla: yes
|
I'll update docs if/when this is deemed an acceptable approach. |
mgoodness
changed the title
There was a problem hiding this comment.
Thanks @mgoodness, I think this is the approach we should take in other charts.
| {{- if .Values.alertmanager.persistentVolume.storageClass -}} | ||
| volume.beta.kubernetes.io/storage-class: {{ .Values.alertmanager.persistentVolume.storageClass }} | ||
| {{ else }} | ||
| volume.alpha.kubernetes.io/storage-class: '' |
There was a problem hiding this comment.
According to http://kubernetes.io/docs/user-guide/persistent-volumes/#writing-portable-configuration we should set it to default (although I don't think it actually makes a difference)
There was a problem hiding this comment.
Let me add that real quick.
|
@k8s-bot ok to test |
mgoodness
changed the title
|
Also added documentation for the new |
|
lgtm! Thanks a lot @mgoodness!! |
This changes all the various pvc.yaml files to use tha pattern shown in helm#235 This also includes a simple sed -i replacement to comment out the storageClass values in the various values.yaml
Addresses #227, based on input from #116.
Alpha dynamic provisioner only looks for annotation, not value. To enable the beta provisioner, operator provides
.Values.{alertmanager|server}.persistentVolume.storageClass.