Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/minecraft] Update to the recommended pvc patterns. #454

Merged
merged 4 commits into from
Jan 30, 2017

Conversation

AmandaCameron
Copy link
Contributor

This is a split-off of PR #408 to just contain the chart minecraft.
If there's any commonality in changes nessary between this PR and the others that are being submitted at once, please mention them in #408.
Some things to note:

  • This initial PR will not be updating the Chart.yaml's version string, as I feel it should be done manually per-pr once each chart's otherwise acceptable.
  • An automated script created the splits and the PRs, on a per-folder basis under stable, after copying the relevent files from a backup of my local copy of Update all stable PVCs to use recommended pattern. #408

@k8s-ci-robot
Copy link
Contributor

Hi @AmandaCameron. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 20, 2017
@viglesiasce
Copy link
Contributor

@k8s-bot ok to test

@viglesiasce viglesiasce added code reviewed lgtm Indicates that a PR is ready to be merged. UX reviewed and removed awaiting review labels Jan 30, 2017
@prydonius prydonius merged commit 4d3f641 into helm:master Jan 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. code reviewed lgtm Indicates that a PR is ready to be merged. UX reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants