Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/phabricator] Update to the recommended pvc patterns. #459

Merged
merged 9 commits into from
Jan 31, 2017
Merged

[stable/phabricator] Update to the recommended pvc patterns. #459

merged 9 commits into from
Jan 31, 2017

Conversation

AmandaCameron
Copy link
Contributor

This is a split-off of PR #408 to just contain the chart phabricator.
If there's any commonality in changes nessary between this PR and the others that are being submitted at once, please mention them in #408.
Some things to note:

  • This initial PR will not be updating the Chart.yaml's version string, as I feel it should be done manually per-pr once each chart's otherwise acceptable.
  • An automated script created the splits and the PRs, on a per-folder basis under stable, after copying the relevent files from a backup of my local copy of Update all stable PVCs to use recommended pattern. #408

@k8s-ci-robot
Copy link
Contributor

Hi @AmandaCameron. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 20, 2017
@prydonius prydonius mentioned this pull request Jan 27, 2017
Closed
30 tasks
@viglesiasce
Copy link
Contributor

@k8s-bot ok to test

viglesiasce
viglesiasce suggested changes Jan 31, 2017
View reviewed changes
stable/phabricator/templates/NOTES.txt
export APP_PASSWORD=$(printf $(printf '\%o' `kubectl get secret --namespace {{ .Release.Namespace }} {{ template "fullname" . }} -o jsonpath="{.data.phabricator-password[*]}"`))
export APP_DATABASE_PASSWORD=$(printf $(printf '\%o' `kubectl get secret --namespace {{ .Release.Namespace }} {{ template "mariadb.fullname" . }} -o jsonpath="{.data.mariadb-root-password[*]}"`))
export APP_PASSWORD=$(kubectl get secret --namespace {{ .Release.Namespace }} {{ template "fullname" . }} -o jsonpath="{.data.phabricator-password}" | base64 --decode)
export APP_DATABASE_PASSWORD=$(kubectl get secret --namespace {{ .Release.Namespace }} {{ template "mariadb.fullname" . }} -o jsonpath="{.data.mariadb-root-password}" | base64 --decode)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs conditional here as this is empty by default.

@k8s-ci-robot
Copy link
Contributor

@AmandaCameron: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins Charts e2e f3df3b6 link @k8s-bot e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@viglesiasce viglesiasce added code reviewed lgtm Indicates that a PR is ready to be merged. UX reviewed and removed changes needed labels Jan 31, 2017
@prydonius prydonius merged commit fbf4d8d into helm:master Jan 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viglesiasce viglesiasce viglesiasce requested changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. code reviewed lgtm Indicates that a PR is ready to be merged. UX reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AmandaCameron @k8s-ci-robot @viglesiasce @prydonius