Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add command telemetry:add #3041

Merged
merged 5 commits into from
Oct 17, 2024
Merged

feat: add command telemetry:add #3041

merged 5 commits into from
Oct 17, 2024

Conversation

k80bowman
Copy link
Contributor

Description

Adds the telemetry:add command. This command should:

  • Function for either an app or a space
  • Require an argument with JSON-formatted headers
  • Only accept a combination of traces, metrics, and logs or all as a value for the --signal flag
  • Set the signal to traces, metrics, logs if no value is provided for the --signal flag

Internal work item

@k80bowman k80bowman requested a review from a team as a code owner October 17, 2024 18:56
justinwilaby
justinwilaby approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k80bowman k80bowman mentioned this pull request Oct 17, 2024
Merged
@k80bowman k80bowman merged commit 090c1a8 into prerelease/10.0.0-alpha Oct 17, 2024
8 checks passed
@k80bowman k80bowman deleted the k80/telemetry-add branch October 17, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinwilaby justinwilaby justinwilaby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k80bowman @justinwilaby