refactor: async/await #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit test for |
curbengh
commented
Dec 22, 2019
| date: item.date, | ||
| tags: item.categories, | ||
| excerpt: tomd.turndown(item.description || ''), | ||
| content: tomd.turndown(item.content || item.description || '') |
There was a problem hiding this comment.
plan to implement a feature to request from the post's url if item.content is absent, in a separate PR.
curbengh
commented
Dec 22, 2019
| } | ||
|
|
||
| if (feed) { | ||
| for (const item of feed.items) { |
There was a problem hiding this comment.
the loop here can be utilized to limit new posts (#9), to do in future PR.
curbengh
force-pushed
the
async
branch
2 times, most recently
from
698782d to
74c6754
Compare
This was referenced Dec 26, 2019
|
Tested with a dummy rss2.xml. |
SukkaW
reviewed
Jan 1, 2020
curbengh
commented
Jan 2, 2020
| if (/^http(s)?:\/\//i.test(source)) { | ||
| stream = request(source); | ||
| input = await got(source, { resolveBodyOnly: true, retry: 0 }); |
There was a problem hiding this comment.
retry is disabled to pass the unit test (in local machine with slow connection).
The got options can be exposed to config in a separate PR.
BREAKING CHANGE: Drops Node 8 - necessary to support got v10
This was referenced Jan 4, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31
BREAKING CHANGE: Drops Node 8
got v10 requires Node 10