Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: requires at least Node 10.18 #56

Merged
merged 2 commits into from
Jan 18, 2020
Merged

chore: requires at least Node 10.18 #56

merged 2 commits into from
Jan 18, 2020

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Jan 11, 2020 •
edited
Loading

I'm rewriting this plugin and intend to replace request with got which depends on Node >=10.

Related: hexojs/hexo-migrator-rss#34

SukkaW
SukkaW approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this plugin is under refactoring, I believe a major version bump is acceptable.

@tomap tomap merged commit ce949c9 into hexojs:master Jan 18, 2020
@curbengh curbengh deleted the drop-node-8 branch February 17, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

@tomap tomap tomap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curbengh @tomap @SukkaW