Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(load_database): enable 'database load failed' #3975

Merged
merged 5 commits into from
Jan 7, 2020

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Dec 16, 2019

What does it do?

Added a workaround for the EPERM error in Windows.

Might as well refactor to async/await #3328.

How to test

git clone -b db-load-windows https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

coveralls commented Dec 16, 2019

Coverage Status

Coverage increased (+0.06%) to 97.142% when pulling 9255530 on curbengh:db-load-windows into 663f1eb on hexojs:master.

@curbengh curbengh force-pushed the db-load-windows branch 2 times, most recently from a392d17 to 5b4f87e Compare December 16, 2019 11:41
@curbengh curbengh mentioned this pull request Dec 16, 2019
2 tasks
@curbengh curbengh marked this pull request as ready for review December 16, 2019 12:23
@curbengh curbengh force-pushed the db-load-windows branch 2 times, most recently from 3146282 to f44149e Compare December 20, 2019 00:54
@SukkaW SukkaW merged commit 61a25e4 into hexojs:master Jan 7, 2020
@curbengh curbengh deleted the db-load-windows branch January 10, 2020 07:10
@curbengh
Copy link
Contributor Author

There is still EPERM: operation not permitted soft error.

thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
…ojs#3975)

* test(load_database): enable 'database load failed'

* refactor(test-load_database): async/await

* style: remove comment

* refactor(test-load_database): destructure

* style: asyncArrow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants