-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: comment out missing tests #3976
Conversation
test/scripts/console/deploy.js
Outdated
@@ -77,7 +77,7 @@ describe('deploy', () => { | |||
}); | |||
}); | |||
|
|||
it('deployer not found'); | |||
// it('deployer not found'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using x pending
to show missing test, I suggest to add a note, like
// it('deployer not found'); missing-unit-test
Then we can mention it in the roadmap, and contributor can simply search for "missing-unit-test" to locate missing tests.
// return fs.exists(dbPath); | ||
// }).then(exist => { | ||
// exist.should.be.false; | ||
// })); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it do?
Not very keen on 'x pending' message at the end of unit test.
I added "missing-unit-test" to the comment. We can mention it in the roadmap, and contributor can simply search for the keyword to locate missing tests.
Add a missing test for list_archives helper.
load_database test is being worked on #3975
Revert #3742
How to test
Screenshots
Pull request tasks