-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore) Fix typescript type exports #3073
Conversation
c158e5d
to
fee59ef
Compare
@joshgoebel can you please backport this into v10? I'd be happy to migrate to v11, but unfortunately I can't, because I use dynamic imports, see webpack/webpack#13865 |
V10.0 is about to drop off the supported list entirely. The core team really does not have time to support multiple versions. Even a PR here isn't super trivial as it would have to pull over the new changes but then also back out the changes to types that occurred between 10 -> 11.
|
If the exports was a huge issue we might perhaps drop them entirely, but it seems only a few broken tools are having issues and that mostly everything else works - unless others would like to chime in here. |
More context: we're developing a component library, and our Source: https://github.com/JetBrains/ring-ui/blob/typescript/components/code/code.tsx#L15-L21 |
Well, I'm not a webpack person I have no idea what the magic comment is trying to do but I'd imagine for dynamic run-time dependencies (via import) you would just use the new ESM CDN builds that we publish (as of 11.2) unmodified... the grammars are all package up in individual files for dynamic usage... and the "main" Highlight.js bundle could be:
|
Resolved #2945.
Changes
Checklist
CHANGES.md