-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump highlight.js from 10.7.3 to 11.3.1 #1901
Conversation
7aad5b5
to
8f751b2
Compare
8f751b2
to
3980c33
Compare
I had a brief look at this and the failure seems to be caused by the update of highlight js. |
Looks like highlightjs/highlight.js#3223 (comment) due to the fact that we also do that kind of dynamic import: https://github.com/nextcloud/text/blob/master/src/EditorFactory.js#L51 |
So looks like it's a bug in webpack with a few options to work around. |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
webpack/webpack#13865 is breaking this - but the workaround in #1915 did not work. So I'll reopen this so we do not lose track of it. |
3980c33
to
e65090e
Compare
e65090e
to
185caa5
Compare
185caa5
to
7b38509
Compare
7b38509
to
dbde392
Compare
dbde392
to
5a4c8cd
Compare
5a4c8cd
to
761c9c9
Compare
Bumps [highlight.js](https://github.com/highlightjs/highlight.js) from 10.7.3 to 11.3.1. - [Release notes](https://github.com/highlightjs/highlight.js/releases) - [Changelog](https://github.com/highlightjs/highlight.js/blob/main/CHANGES.md) - [Commits](highlightjs/highlight.js@10.7.3...11.3.1) --- updated-dependencies: - dependency-name: highlight.js dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
761c9c9
to
829a75e
Compare
I found a workaround for the webpack issue in #1942. However there's another issue with dependencies as the Highlight plugin of tiptap-extensions seems to be bound to lowlight 1.x which is not compatible with highlight.js 11.x. So closing this and giving up until we migrate to tiptap2 or so. |
Bumps highlight.js from 10.7.3 to 11.3.1.
Release notes
Sourced from highlight.js's releases.
... (truncated)
Changelog
Sourced from highlight.js's changelog.
... (truncated)
Commits
2a972d8
(chore) remove extra linebreak175b856
(release) bump 11.3.13d1836f
(chore) add tiny header to HLJS grammar modules76efccf
(fix/chore) safer wrapper for IIFE grammar plugins0ce3979
11.3.0fbf9534
fix(js/ts) fix detecting types as JSX (#3278)0f70132
(chore) export namedHighlightJS
export in Node packages (#3307)7315fb1
enh(css) add support for hex color alpha channel (#3360) (#3362)7cb4e3d
enh(nsis) adds NSIS v3.08 commands, some small improvements (#3351)fc35be5
fix(css/scss/less/stylus) support single colon when using pseudo element sele...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)