Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angle Constraint Bug - $50 #261

Open
Tracked by #260
hlorus opened this issue Aug 19, 2022 · 8 comments
Open
Tracked by #260

Angle Constraint Bug - $50 #261

hlorus opened this issue Aug 19, 2022 · 8 comments
Labels
Bounty - Small https://www.cadsketcher.com/cad-sketcher-bounty-board

Comments

@hlorus
Copy link
Owner

hlorus commented Aug 19, 2022

The angle constraint fails to solve in some scenarios, see:
https://www.youtube.com/watch?v=yHC8NQG2A2Y&t=4s @01:23

@hlorus hlorus mentioned this issue Aug 19, 2022
4 tasks
@amrsoll amrsoll changed the title Angel Constraint Bug - $50 Angle Constraint Bug - $50 Aug 22, 2022
@amrsoll
Copy link
Collaborator

amrsoll commented Aug 22, 2022

Managed to recreate a minimal example. When trying to set the angle to for example 50 degrees, it breaks.

https://nextcloud.soll.xyz/index.php/s/C86ZiMD5y7jxzR4

image

@amrsoll
Copy link
Collaborator

amrsoll commented Aug 22, 2022

Uncaught exception happens when solving the system

uncaught exception

Pointing to this particular line

Compared to the upstream solvesystem repo, the one we use with the python bindings is 1100 commits behind. I think the realthunder/solvespace repo desperatly needs an update from upstream.

It might be worth trying this version instead: https://github.com/KmolYuan/solvespace

https://pypi.org/project/python-solvespace/

But I think @hlorus knows best about the different python ports of solvespace.

@amrsoll
Copy link
Collaborator

amrsoll commented Aug 23, 2022

Even more minimal example using 2 lines, vertical or horizontal constraint + vertical / horizontal Distance constraint

image

@hlorus
Copy link
Owner Author

hlorus commented Aug 23, 2022

Compared to the upstream solvesystem repo, the one we use with the python bindings is 1100 commits behind. I think the realthunder/solvespace repo desperatly needs an update from upstream.

Absolutely agree with that, we should probably reach out to realthunder.

It might be worth trying this version instead: https://github.com/KmolYuan/solvespace
https://pypi.org/project/python-solvespace/

That's actually what i used to start with but i've decided to switch to the version that is used now back because it didn't seem to be maintained iirc.

But I think @hlorus knows best about the different python ports of solvespace.

I don't really know alot about the differences. There's just no available python package of the official solvespace solver as far as i know.

@amrsoll
Copy link
Collaborator

amrsoll commented Aug 23, 2022

it didn't seem to be maintained iirc.

The https://github.com/KmolYuan/python-solvespace is archived, but he also has https://github.com/KmolYuan/solvespace which is maintained and a lot closer to upstream. I'm trying to use it atm, but there are quite a few differences (obvi)

@therealjacobbrauer
Copy link
Contributor

Uncaught exception happens when solving the system

uncaught exception

Pointing to this particular line

Compared to the upstream solvesystem repo, the one we use with the python bindings is 1100 commits behind. I think the realthunder/solvespace repo desperatly needs an update from upstream.

It might be worth trying this version instead: https://github.com/KmolYuan/solvespace

https://pypi.org/project/python-solvespace/

But I think @hlorus knows best about the different python ports of solvespace.

in your code shown here, how are you running the solver.py script? Do you run the solver.py from your python IDE? Sorry for the basic question, I really appreciate your input on these GitHub pages amrsoll.

@amrsoll
Copy link
Collaborator

amrsoll commented Sep 2, 2022

@therealjacobbrauer

in your code shown here, how are you running the solver.py script? Do you run the solver.py from your python IDE? Sorry for the basic question, I really appreciate your input on these GitHub pages amrsoll

No worries :) I created a vscode file that runs a debug server and connects to the vscode debug client. It should happen before right after all the imports in the addons are done.

If using VSCode / Codium you should be able to press F5 to run the selected debugger

See #206

@vespakoen
Copy link
Collaborator

vespakoen commented Jan 14, 2023

I git bisected this issue because it seemed to work at some point in the past.
This bug (at least with the first example (#261 (comment), angle_break.blend) seems to be broken by this commit:

4caa0fc#diff-116ba881a2b88b2046ed43e0ccf5660900385cdfd8bb3beea1a41a7cc6c49f83

Here is the corrosponding PR:

#272

@hlorus hlorus added the Bounty - Small https://www.cadsketcher.com/cad-sketcher-bounty-board label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounty - Small https://www.cadsketcher.com/cad-sketcher-bounty-board
Projects
None yet
Development

No branches or pull requests

4 participants