-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor for python_solvespace API. #268
Conversation
You said "same user" but I don't see any sign of it on realthunder's page. Can you link to the python_solvespace repo you're using? |
Definitely intresting to explore this direction. My main question here is if we would have to drop support for the current python port "py_slvs". Some people also pointed completely different solvers out. Maybe we could start thinking about having it somewhat generic to allow plugging in any solver we want in the future. |
There doesn't immediately seem like there is any advantage of using py_slvs over python_solvespace (god I hate when python packages put py/python in their name 😂 )
Oh the nightmare 😂 given how differently some solvers and their API might work (imagine something acting as weirdly as |
Hmm yeah, might not be worth the hassle to support multiple solvers. |
Interestingly i'm already failing at installing the solver... At least for the latest version, it worked with version 3.0.0.post7 |
This will likely need alot of testing so i would recommend making this an official branch, getting it to a testable stage and then collect feedback by testers. |
Well i am happy not to be the only one to want this tested out, see if it works better :) |
Closing this PR as a duplicate of #320 |
Why?
The PR is currently a draft to feel the temperature of the water and talk about it.
The python_solvespace repo is much closer to the upstream solvespace repo. This means that some bugs might already be solved there, such as #261 (not confirmed if this can fix it)
A side effect of this refactor is that a lot of abstraction is already done by the python wrapper 😄 and saves a lot of lines.
History
@hlorus used to base CAD sketcher on an other solvespace repo . As it got archived it seemed to be abandonned, but an other fork was maintained by the same user.
TODO