Fixed a bug where the group and label of a Holomap would get messed u…

[drs251]

…p by ElementOperation.call - #1106

[drs251]

Hope I didn't screw this up too badly, it's my first PR ever... 😊

[jlstevens]

Looks good, thanks!

I'm just trying to remember the original reasoning we had for copying the group/label across...

[drs251]

Manual copying seems to be unnecessary, as this is done by clone() - I've tested it.

[philippjfr]

I think this is correct, it doesn't make sense for a HoloMap to inherit the group and label of the input since it already computes a new group and label from the processed Elements. I expect there to be a lot of test failures, so we'll have to update the test data.

[philippjfr]

Only one small failure in Showcase, where contours, threshold and gradient operations are used. No change in display data though. Rebuilding tests now.

[philippjfr]

@jlstevens Seems the PR build here failed uploading the test data:

upload failed: ./test_data.zip to s3://preview.holoviews.org/6556/test_data_py2.zip Unable to locate credentials

any ideas?

[jlstevens]

Hmm, I'm guessing it is this line

I have vague memories of the AWS key being encrypted as an environment variable. I assume there is a credentials issue for some unknown reason...

[philippjfr]

@drs251 Sorry about holding this up but we uncovered an issue in our testing infrastructure which I've only just fixed. Do you mind merging or rebasing this PR against current master, then I'll be able to merge it.

[drs251]

@philippjfr I've managed to update personal fork and merge the PR there, but I can't figure out how to modify this PR to the main repo - or should I make a completely new PR? (Sorry, GitHub is kind of new to me...)

[drs251]

@philippjfr Never mind, I think i figured it out, but the test is still failing for some reason... 😦

[philippjfr]

@drs251 Perfect thanks! The test failure is expected, we test the output of all our tutorial notebooks and one of them has changed slightly with this PR. I'm about to rebuild the test data and then merge.

[philippjfr]

Sorry again, it seems your merges weren't quite right. Perhaps the easiest thing would be to reopen the PR starting with current master. Alternatively I'd be happy to resubmit the PR myself, you'd still be the commit author, but I don't want to steal the glory of your first merged PR.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.