-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support comparing date-like objects #629
Conversation
Codecov Report
@@ Coverage Diff @@
## master #629 +/- ##
==========================================
+ Coverage 82.91% 83.07% +0.15%
==========================================
Files 5 5
Lines 3073 3084 +11
==========================================
+ Hits 2548 2562 +14
+ Misses 525 522 -3
Continue to review full report at Codecov.
|
@philippjfr I've seen you added the However this test is failing because the code did not handle any other type than the ones declared in the
|
I've removed the identity check, not because I think we shouldn't do it but because it's a change in behavior and we need to consider it carefully. Please open a new issue or PR to discuss further. |
MacOS tests passed but coveralls errored for some reason. Merging. |
This was a codecov issue (codecov/codecov-action#745) that is now resolved. |
Discovered this bug while working on holoviz/lumen#276
The
Comparator
class didn't supportdatetime.date
,datetime.datetime
andnp.datetime64
object. This meant that, if a parameter value was set to its old value, Param would still see it as a new value and would let potential watchers be executed, while they should not. This caused problems for Panel bidirectional links which don't check for equality but rely on Param.I see that other types aren't supported, like Numpy Arrays, Pandas DataFrame, or frozensets. If more types should be added, let's come up with a list and add them in another PR.