Don't assume numpy/pandas is available in guess_param_types
#630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #630 +/- ##
==========================================
+ Coverage 83.07% 84.26% +1.18%
==========================================
Files 5 5
Lines 3084 3088 +4
==========================================
+ Hits 2562 2602 +40
+ Misses 522 486 -36
Continue to review full report at Codecov.
|
jbednar
reviewed
May 19, 2022
jbednar
approved these changes
May 20, 2022
philippjfr
force-pushed
the
guessparamtypes_guard_pandasnumpy
branch
from
0c35872 to
456172a
Compare
philippjfr
reviewed
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the suggestion in #629 (comment), needs #629 to be merged first
guess_param_typesis actually not used at all across HoloViz and not documented. The PR that added this utility - #317 - says that it "has cropped up several times and has resulted in some level of code duplication" and points to HoloViews Streams.define classmethod which indeed could make use of this utility, since it's basically inlining a partial implementation of it.#317 provides more details about the usefulness of this utility, and on the conversions it doesn't yet support.