Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated forecast attribute from WeatherEntity #110761

Merged
merged 15 commits into from
Mar 27, 2024

Conversation

gjohansson-ST
Copy link
Member

@gjohansson-ST gjohansson-ST commented Feb 16, 2024

Breaking change

The previously deprecated forecast attribute in Weather has now been removed.

Proposed change

Remove deprecated forecast attribute from WeatherEntity

Awaiting:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (weather) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of weather can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign weather Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot]

This comment was marked as outdated.

@home-assistant home-assistant bot marked this pull request as draft February 22, 2024 17:36
@home-assistant

This comment was marked as outdated.

@gjohansson-ST gjohansson-ST force-pushed the weather-remove-depr-forecast branch from f5b851a to 9abd5cc Compare February 22, 2024 17:39
@gjohansson-ST gjohansson-ST marked this pull request as ready for review February 22, 2024 19:56
@gjohansson-ST gjohansson-ST marked this pull request as draft February 23, 2024 21:12
@gjohansson-ST gjohansson-ST marked this pull request as ready for review February 23, 2024 21:31
@gjohansson-ST gjohansson-ST marked this pull request as draft March 6, 2024 21:19
@gjohansson-ST gjohansson-ST force-pushed the weather-remove-depr-forecast branch from 1aec589 to 6b38588 Compare March 16, 2024 10:43
@gjohansson-ST gjohansson-ST marked this pull request as ready for review March 16, 2024 10:44
@gjohansson-ST gjohansson-ST force-pushed the weather-remove-depr-forecast branch 2 times, most recently from f56f6b6 to 22bdda1 Compare March 25, 2024 20:44
frenck
frenck previously requested changes Mar 27, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gjohansson-ST There is a merge conflict, could you rebase this one?

../Frenck

@home-assistant home-assistant bot marked this pull request as draft March 27, 2024 10:07
@gjohansson-ST gjohansson-ST force-pushed the weather-remove-depr-forecast branch from 22bdda1 to ae6b1a9 Compare March 27, 2024 14:04
@gjohansson-ST gjohansson-ST marked this pull request as ready for review March 27, 2024 14:05
@home-assistant home-assistant bot requested a review from frenck March 27, 2024 14:05
@home-assistant home-assistant bot marked this pull request as draft March 27, 2024 15:08
@gjohansson-ST gjohansson-ST marked this pull request as ready for review March 27, 2024 15:16
@home-assistant home-assistant bot requested a review from emontnemery March 27, 2024 15:16
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gjohansson-ST 👍

@gjohansson-ST gjohansson-ST added this to the 2024.4.0b0 milestone Mar 27, 2024
@gjohansson-ST gjohansson-ST merged commit 6523090 into dev Mar 27, 2024
31 checks passed
@gjohansson-ST gjohansson-ST deleted the weather-remove-depr-forecast branch March 27, 2024 15:51
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants