Remove hourly weather entity from NWS

[gjohansson-ST]

Breaking change

The nws integration previously created two entities for each configured location, one entity which provided daily weather forecasts and one entity which provided hourly forecasts. The nws integration now only creates a single entity which provides both daily and hourly weather forecasts.

Proposed change

Remove the hourly weather entity from nws and instead provide hourly + daily forecasts in one entity

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @MatthewFlamm, @kamiyo, mind taking a look at this pull request as it has been labeled with an integration (nws) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of nws can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign nws Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[MatthewFlamm]

At some point we can assume that users will no longer have this entity. Should we aim to remove this code at some point, and add a comment to this effect? Or are we committing to keeping this around?

[gjohansson-ST]

6 releases is the general deprecation time so I guess that's relevant here too for cleaning this up eventually.

[MatthewFlamm]

The available code also no longer works if the user is expecting that this will also represent the availability of the hourly forecast data. To be consistent we should probably remove the forecast coordinator or expand to using both forecast coordinators.

Unfortunately if we expand to check all coordinators last success to check for availability, this combined hourly and twice daily forecast structure will make it even more likely for this entity to show unavailable.

[kamiyo]

I don't know how many days the forecasts are usually, but can we cache the results and only return false from available if neither last update did not succeed nor is there any current data in the forecast (last forecast date < now)?

[MatthewFlamm]

I don't know how many days the forecasts are usually, but can we cache the results and only return false from available if neither last update did not succeed nor is there any current data in the forecast (last forecast date < now)?

The way it works currently is similar but slightly different. If the last success time was within some time period from now then it is considered available, otherwise unavailable. This PR keeps this, but we now only have one entity with two forecast coordinators. Only one forecast coordinator is used to determine availability. I worry that including both will cause extra 'unavailable' times for users who just want one forecast. The NWS servers are flaky enough that this is a problem. But not including them all will result in potentially more stale forecasts to be shown.

[gjohansson-ST]

Changing the behavior of the available property and/or adjusting the coordinators are not in scope of this PR so feel free to do so in a separate PR in a follow-up 👍

[MatthewFlamm]

This generally LGTM. However, I think it would be good to have feedback on how much time must elapse before we can assume users no longer have the hourly entity to clean up the code.

[frenck]

Thanks, @gjohansson-ST 👍

../Frenck