Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward only key fields to peers #1318

Closed
VinozzZ opened this issue Sep 10, 2024 · 1 comment
Closed

Forward only key fields to peers #1318

VinozzZ opened this issue Sep 10, 2024 · 1 comment
Assignees
@VinozzZ
Milestone
v2.9

Comments

@VinozzZ
Copy link
Contributor

VinozzZ commented Sep 10, 2024 •
edited
Loading

We will extend the existing peer span forwarding system to include forwarding a “proxy span” to its decider node. This proxy span will include:

  • Key fields necessary for trace decisions (this can be empty if no key fields are present).
  • A marker that differentiates proxy spans from normal spans.

Conditions for Forwarding a Proxy Span:

  • ForceTraceLocality is set to false.
  • A new span arrives, even if it does not contain any key fields.

Ignoring Proxy Spans:
When sending spans to Honeycomb, Refinery should ignore proxy spans by checking the marker to ensure they are not forwarded.
@VinozzZ VinozzZ added this to the v2.9 milestone Sep 10, 2024
@VinozzZ VinozzZ self-assigned this Sep 12, 2024
This was referenced Sep 16, 2024
Closed
Closed
@MikeGoldsmith
Copy link
Contributor

Requires the following issue to be resolved first:

This was referenced Sep 17, 2024
Merged
Merged
VinozzZ added a commit that referenced this issue Sep 30, 2024
@VinozzZ
feat: extract decision span from full span (#1338)
1d70862 
## Which problem is this PR solving?

Extract only necessary information that's needed for trace decision from
a full span so that we can forward only the key fields to peers later
part of #1318 

## Short description of the changes

- add a method on `Span` to extract only necessary information into a
new types.Event
- add a method to differentiate a full span from a decision span
- store `IsRoot` information on `Span`
- simplify naming for span annotation types
VinozzZ added a commit that referenced this issue Oct 2, 2024
@VinozzZ
feat: forward decision span through peer endpoint (#1342)
0eac5f0 
## Which problem is this PR solving?

implements: #1318 #1326 

## Short description of the changes

- Add a new config option `ForceTraceLocality` to turn off trace
distribution feature
- forward decision spans when peer membership changes
TylerHelmuth pushed a commit that referenced this issue Oct 16, 2024
@VinozzZ @TylerHelmuth
feat: extract decision span from full span (#1338)
19986e4 
Extract only necessary information that's needed for trace decision from
a full span so that we can forward only the key fields to peers later
part of #1318

- add a method on `Span` to extract only necessary information into a
new types.Event
- add a method to differentiate a full span from a decision span
- store `IsRoot` information on `Span`
- simplify naming for span annotation types
TylerHelmuth pushed a commit that referenced this issue Oct 16, 2024
@VinozzZ @TylerHelmuth
feat: forward decision span through peer endpoint (#1342)
f4d3f9f 
implements: #1318 #1326

- Add a new config option `ForceTraceLocality` to turn off trace
distribution feature
- forward decision spans when peer membership changes
@VinozzZ VinozzZ closed this as completed Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VinozzZ VinozzZ

Labels
None yet
Projects
None yet
Milestone
v2.9
Development

No branches or pull requests
2 participants
@MikeGoldsmith @VinozzZ