Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: forward decision span through peer endpoint #1342

Merged
merged 8 commits into from
Oct 2, 2024
Merged

feat: forward decision span through peer endpoint #1342

merged 8 commits into from
Oct 2, 2024

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Sep 18, 2024

Which problem is this PR solving?

implements: #1318 #1326

Short description of the changes

  • Add a new config option ForceTraceLocality to turn off trace distribution feature
  • forward decision spans when peer membership changes

@VinozzZ VinozzZ self-assigned this Sep 18, 2024
@VinozzZ VinozzZ added this to the v2.9 milestone Sep 18, 2024
@VinozzZ VinozzZ force-pushed the yingrong.forward_decision_span branch 3 times, most recently from 66ee950 to d392bc1 Compare September 19, 2024 20:33
Base automatically changed from yingrong.decision_span to main September 30, 2024 18:01
@VinozzZ VinozzZ force-pushed the yingrong.forward_decision_span branch from 885383a to 6b739c2 Compare September 30, 2024 18:12
@VinozzZ VinozzZ marked this pull request as ready for review September 30, 2024 20:04
@VinozzZ VinozzZ requested a review from a team as a code owner September 30, 2024 20:04
MikeGoldsmith
MikeGoldsmith reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - left some feedback regarding new config field name.

types/event.go Show resolved Hide resolved
config/metadata/configMeta.yaml Outdated Show resolved Hide resolved
config/file_config.go Outdated Show resolved Hide resolved
MikeGoldsmith
MikeGoldsmith approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@VinozzZ VinozzZ merged commit 0eac5f0 into main Oct 2, 2024
5 checks passed
@VinozzZ VinozzZ deleted the yingrong.forward_decision_span branch October 2, 2024 20:14
TylerHelmuth pushed a commit that referenced this pull request Oct 16, 2024
@VinozzZ @TylerHelmuth
feat: forward decision span through peer endpoint (#1342)
f4d3f9f 
implements: #1318 #1326

- Add a new config option `ForceTraceLocality` to turn off trace
distribution feature
- forward decision spans when peer membership changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Assignees

@VinozzZ VinozzZ

Labels
None yet
Projects
None yet
Milestone
v2.9
Development

Successfully merging this pull request may close these issues.
2 participants
@VinozzZ @MikeGoldsmith