Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuration values to be specified for the cluster rather than the instance #608

Closed
kentquirk opened this issue Feb 14, 2023 · 1 comment · Fixed by #827
Closed

Allow configuration values to be specified for the cluster rather than the instance #608

kentquirk opened this issue Feb 14, 2023 · 1 comment · Fixed by #827
Milestone
v2.1

Comments

@kentquirk
Copy link
Contributor

kentquirk commented Feb 14, 2023 •
edited
Loading

There are configuration values in Refinery, such as the GoalThroughputPerSec value used by the TotalThroughputSampler, that are calculated based on the value for a single instance, but the customer experience is to see refinery as an entire cluster. Can we find a way to allow these values to be adjusted by refinery based on the number of peers in the cluster?

This makes it easier to think about as well as meaning that the value wouldn't have to be adjusted when cluster size changes.
@TylerHelmuth
Copy link
Contributor

Related to #560

@kentquirk kentquirk added this to the v2.0 milestone Apr 15, 2023
@kentquirk kentquirk modified the milestones: v2.0, v2.1 Jun 20, 2023
@MasonLegere MasonLegere mentioned this issue Jul 24, 2023
Open
@kentquirk kentquirk mentioned this issue Aug 2, 2023
Merged
kentquirk added a commit that referenced this issue Aug 3, 2023
@kentquirk
feat: Allow setting throughput for the cluster (#827)
08b1b7d 
## Which problem is this PR solving?

- Throughput samplers now have an extra flag, `UseClusterSize`, which
causes the `GoalThroughputPerSec` to be divided by the number of
Refinery nodes in the cluster. This way, when cluster size changes, the
configuration doesn't need to be changed.

## Short description of the changes

- Add the flag to the config
- Update metadata for the new flag
- Add code to 3 throughput samplers to support it
- Write tests to verify it works
- Regenerate docs

Fixes #533.
Fixes #608.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1
Development

Successfully merging a pull request may close this issue.

feat: Allow setting throughput for the cluster honeycombio/refinery
2 participants
@kentquirk @TylerHelmuth