Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow setting throughput for the cluster #827

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

  • Throughput samplers now have an extra flag, UseClusterSize, which causes the GoalThroughputPerSec to be divided by the number of Refinery nodes in the cluster. This way, when cluster size changes, the configuration doesn't need to be changed.

Short description of the changes

  • Add the flag to the config
  • Update metadata for the new flag
  • Add code to 3 throughput samplers to support it
  • Write tests to verify it works
  • Regenerate docs

Fixes #533.
Fixes #608.

@kentquirk kentquirk requested a review from a team as a code owner August 2, 2023 23:00
config/metadata/rulesMeta.yaml Show resolved Hide resolved
sample/ema_throughput.go Outdated Show resolved Hide resolved
sample/sample.go Show resolved Hide resolved
@kentquirk kentquirk force-pushed the kent.use_cluster_size branch from 48e6dee to eb3fc08 Compare August 3, 2023 19:26
@kentquirk kentquirk requested a review from TylerHelmuth August 3, 2023 19:29
@kentquirk kentquirk requested a review from TylerHelmuth August 3, 2023 21:06
@kentquirk kentquirk merged commit 08b1b7d into main Aug 3, 2023
@kentquirk kentquirk deleted the kent.use_cluster_size branch August 3, 2023 22:00
@kamalmarhubi
Copy link

Amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants