Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use HTTP/2 for all upstream and peer-to-peer connections #1269

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

irvingpop
Copy link
Contributor

Which problem is this PR solving?

  • Refinery currently uses HTTP/1 for all outbound connections, both to upstream and peers. In Classic settings this is fine, but in E&S settings with very high service counts this can result in thousands of new connections made per minute, and a heavy toll on any intermediary proxies.
  • According to Go's http.Transport documentation, it conservatively disables HTTP/2 because we're passing in Dial.

Short description of the changes

  • This PR sets the flag to tell Go's http.Transport that it's okay to go ahead and attempt HTTP/2 if available.
  • I've put the upstream aspect of this through heavy testing so far, but not the peer-to-peer aspect. I imagine it may provide benefit to customers with service meshes, and marginal benefit to Linux kernels in general to track fewer connections.

@irvingpop irvingpop requested a review from a team as a code owner August 13, 2024 15:52
Copy link
Contributor

@VinozzZ VinozzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@VinozzZ VinozzZ changed the title Use HTTP/2 for all upstream and peer-to-peer connections fix: Use HTTP/2 for all upstream and peer-to-peer connections Aug 13, 2024
@kentquirk kentquirk merged commit 24436a5 into main Aug 13, 2024
6 of 7 checks passed
@kentquirk kentquirk deleted the irving.use_http2 branch August 13, 2024 16:00
kentquirk added a commit that referenced this pull request Sep 4, 2024
kentquirk added a commit that referenced this pull request Sep 4, 2024
#1310)

… (#1269)"

This reverts commit 24436a5.

## Which problem is this PR solving?

- We see what appears to be a memory leak, and it seems like it might be
in the connections, so we're going to try reverting this to see if it
fixes it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants